Pull request overview

Adds additional patron request search/filter capabilities by extending the patron_request schema and introducing a search view used by the list endpoint/CQL filtering. Also tightens supplier/requester lookup to include “side” and exposes the new needsAttention field through the API.

Changes:

• Add needs_attention column and introduce patron_request_search_view with derived search fields.
• Switch patron request listing to read from the new view and expand supported CQL fields.
• Update GetPatronRequestBySupplierSymbolAndRequesterReqId to include side, and propagate through service/tests; expose needsAttention in API responses.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

You can also share your feedback on Copilot code review. Take the survey.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

You can also share your feedback on Copilot code review. Take the survey.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

Auto-action failures still bypass the new needs_attention flag.

finalizeActionExecution() only calls setNeedsAttention() after RunAutoActionsOnStateEntry() returns successfully, but it returns early on auto-action error:

if stateChanged {
    err := a.RunAutoActionsOnStateEntry(ctx, updatedPr, &event.ID)
    if err != nil {
        return events.LogErrorAndReturnResult(ctx, "failed to execute auto action", err)
    }
}

if execResult.outcome == ActionOutcomeFailure && !updatedPr.NeedsAttention {
    a.setNeedsAttention(ctx, updatedPr)
}

That means a request can transition successfully, hit an auto action from the state model (NEW -> validate, supplier VALIDATED -> will-supply, etc.), fail there, and return an error without ever being marked for attention.

I think this is a behavioral gap relative to the new feature, since auto-triggered actions are still actions and their failures are exactly the kind of case an operator would need surfaced.